NMS-10565: more improvements to shell scripts (#2359)
* NMS-10565: more improvements to shell scripts
* allow overriding JAVA_SEARCH_DIRS in `find-java.sh` for testing
* allow specifying an individual java path to check in `find-java.sh`
* support skipping the default JAVA_SEARCH_DIRS in `find-java.sh`
* change `runjava` to always use `find-java.sh` if possible to
validate java versions, which has stricter/better version-processing
* allow adding one or more additional search paths to the `runjava`
command-line to aid in testing
* resolve symlinks to make it easier to know what the "real"
$JAVA_HOME being resolved is
* add tests for `find-java.sh`
* more test coverage for `runjava` including searching multiple
test JDK directories
* fix shunit2 `assertEquals` (expected is the 2nd arg, not 1st)
* NSM-10565: make sure HOME is not set during tests (avoid ~/.opennms-dev)
* NMS-10565: create a utility library for array and conf handling
This PR changes opennms's `opennms.conf` parsing to handle any
combination of scalar or array-based variables, in multiple
configuration files. This makes sure that mixing and matching
old-style `opennms.conf` from `~/.opennms-dev/` and from
`$OPENNMS_HOME/etc/` behaves properly, and provides robust
guards to make sure environment variables are always turned
into arrays before using them internally.
* convert `opennms` to use `$OPENNMS_HOME/bin/_lib.sh`
* fix `opennms` "dry-run" output to wrap arguments in quotes
to aid in unit testing
* add an additional configuration file from Jesse to test against
* change all `opennms.spec.sh` unit tests to check for quoted
arguments
* NMS-10565: if $TMPDIR is not set, fall back to a dir in /tmp
HZN-1393: Send Topologies updates to Kafka (#2305)
* NMS-9273: Create Topology Service Updates in enlinkd
changes from branch jira/NMS-9273
Created topologies under features with OnmsTopology
Created a method to get a map of ip mac address
in ipnettomediatopologyservice and use it in LinkdTopologyProvider
Fixed package name for topologies in custom.properties
Moved CompositeKey to enlinkd.service.api
Added updaters to enlinkd scheduler
Moved all the Pair logics to enlinkd service api
Created updaters for lldp, ospf isis and bridge
Created a super updaters class
Moved the topo linkd match tests to enlinkd service impl
Fixed distributed impl pom.xml
Added dependency for topolgies.service
and enlinkd.service enlinkd.persistence
* NMS-9273: Create Topology Service Updates in enlinkd
Added ipNetToMediaTopologyservice as a service
to Karaf
* NMS-9273: Create Topology Service Updates in enlinkd
Added nodeid,ifindex and port to ipnettomedia
When the entry is saved then an attempt to
get information from ipinterface and snmpinterface
is done
* NMS-9273: Create Topology Service Updates in enlinkd
Added MacPort that represents an unique port identified by
common found objects mac and ip.
Using the MapPort in LinkdTopologyProvider
* Fixed Header License
* Type OTHER is to be processed for IpNetToMedia
Including also TYPE_IPNETTOMEDIA_OTHER
as valid to be persisted
* NMS-9273: Create Topology Service Updates in enlinkd
Fixed NPE in creating MacPort
Removed comments in LinkdTopologyProvider
Better logs and check for debug in IpNetToMedia
Also same mac address must be mapped to the same macPort
* NMS-9273: Create Topology Service Updates in enlinkd
Moved all the login for calculating topology
to BridgeTopologyService matchBridgeLink method
Moved getMacLinks from ipnetotomediaservice to BridgeTopologyService
Created a static method for generating a LinkdVertex from MacPort
Removing references for ipNetToMediaService in blueprint.xml
* NMS-9273: Create Topology Service Updates in enlinkd
Moved all linkdtopologypropvider data
to enlinkd.service.api
NodeTopologyService provide data fro vertex for LinkdTopoProvider
and EnlinkdUpdaters
Changed the topologies OnmsVertex to be less Linkd centric
* NMS-9273: Create Topology Service Updates in enlinkd
Fix test NMS-9273: Create Topology Service Updates in enlinkd
Avoiding dlupication of row in criteria
guava Table does not support null index
using -1 when the node has no an snmpinterface
* Removed a typo not using super for create
* NMS-9273: Create Topology Service Updates in enlinkd
Added BridgeOnmsTopologyUpdater to enlinkd daemon
Moved all the static method to get the id from LinkdTopologyProvider
to enlinkd service Topology
Implemented the BridgeOnmsBridgeTopologyUpdaters
Changed OnmsTopology objects to support OnmsTopologyShared
* NMS-9273: Create Topology Service Updates in enlinkd
Added TopologyService to enlinkd.service
this will allows updaters to run only
there are updates available
Create implementation for TopologyService and
also using this in bridge,cdp,isis,ospf,lldp
topology services
Enhanced test Nms17216 to check for updates
* Added forgotten files
* NMS-9273: Create Topology Service Updates in enlinkd
EnlinkdOnmsTopologyUpdater send only Topology Changes Messages
Enhanced the OnmsTopology for messaging
Added a test for LldpLinkupdaters
improvedi the TopologyLogger
* NMS-9273: Create Topology Service Updates in enlinkd
Removed protocol from OnmsTopology ref
Throwing OnmsTopologyException
when null object were found
Added a rest service for rendering topologies
using GrapML.
The endpoint 'topologies' will produce the list
of available topologies
The end point 'topologies/{TOPONAME}'
produces graphml data usable
by our graphml topology provider
* HZN-1377: added topologies service impl for test rest
* NMS-9273: Added MacCloud to hold orphan mac address
A shared segment in Topology can have several type
of port end. We add mac that do not have an associated ip
in one vertex as a cloud
Added test for ipnetomedia and getIpMacPort
* NMS-9273-1: Fixed License Header
* Fixed Typo
* Removed a commented row
* Using String.format
* NMS-9273-1: added test for BridgeTopologyUpdater
* NMS-9273-1: Fixed Nms7918EnIt tests
All the test have been revisited and all
have been double checked
Instead of a String it is better to use a class
This class will normalize the use of the protocols
String and let be identify as same Protocol
ignoring case
Added property to hold list of supported
protocol to send message for in
blueprint-kafka-producer.xml
Added topologies.service.api dependecny in pom.
Added implementation in kafka producer.
removed the "Onms" prefix and the "Message" suffix
pushing a delete, we push a null record
updates will send the whole object
created topics for vertices, edges and segments
Added ifAlias to SnmpInterfaceTopologyEntity
Added a method getPort to Topology for
setting up a string with port information
using this method in IpNetToMedia to persist port
ifIndex and ifName fields are already called if_index and if_name
in other message proto from kafka
* Removed eventlistener from NodeDiscoveryBridge
* Topology updaters unregister implementation
Allow only registered upaters to
unregister for specified protocol
* Added reload configuration for enlinkd
Supported reload event for enlinkd.
Added reloadConfig to update configuration and reload daemon
Also let spring instantiate Updaters and BridgeDiscovery
Renamed common classes to NodeCollector and Topologyupdater
* OnmsTopologyLogger has actually received the expected messages
* Removed LOG entry from NodeDiscoveryIpNetToMedia
Removed OnmsTopologySegment
Removed Status NEW, only UPDATE and DELETE
are send as TopologyMessage
Reworked BridgeOnmsTopologyUpdater to
use Edges instead of segment
Updated kafka producer to use only
vertex and edge topics
* Fixed LOG to display protocol name
* Instantiate scheduler in init
The create scheduler is not used elsewehre
* Remove unused core daemon dependency
The core daemon is not need to be imported
into adapters
Reworked LinkdTopologyProvider to
use topologies
Avoiding in such manner any code duplication
All the topology calculation
are made into the proper framework
once
* Always run topology if getTopology is called
run updates if is the first run
* Added test for defaults in TopologyProvider
* Schedule first updaters with initial sleep time 0
* Linkd discovery class improved
The Discovery rules
if is unscheduled do nothing
if is suspended only schedule itself
otherwise rundiscovery and reschedule itself
* Fixed getTopology
* send topology update to kafka
Added documentation for topologies update
to the developer guide
Enlinkd configuration changes
resetting bridge topology interval
a different interval is needed for updaters
using topology_interval
Removed unusuful methods in EnhancedLinkd
related to configuration
update documention on admin guide
Added default config for brodge_topology_discovery
All the configuration properties have been added to
default config file woith default value
* Force loading NODES Updaters
load NODES topology every time getDefault is called
* Force loading topology when is called
LinkdTopologyProvider will call load every
time refresh is called
* Let enlinkd reloadTopology for updaters
added Reload Topology event to Enlinkd
event processor
when triggered the enlind provides to force
topology calculatiopn for updaters.
Minor changes about Enlinkd TopologyMap test
Set up a property for let the topology forced to be calculated
usually topology is build only when the topology service has updates
but in some case (for example the TopologyGenerator) this will not
produce an updates in topologyService.
so it is possible to force updates directly on the updaters
A force reload topology event will produce a build of the topology
also updates are sent to subscribers
* Fix opennms header in vaadin full pages (topology, node maps)
* bootstrap-rework: Migrated Modify-Asset Form Validation
* bootstrap-rework: Removed Debug Message
* Remove unused jsps
* Some cleanup
* Fix empty space when invisible
* Fix sidebar in node graph page
* bootstrap-rework: Migrated Nodemanagement Pages
* bootstrap-rework: Fixed Dashboards-Dashboard Side Navigation
* bootstrap-rework: Fixed Migration Typo in onms-classification
* Use fontawesome instead of glyphicon
* Fix vaadin iframes to be full screen
* Make title smaller
* Migrate situation summary box
* Fix navigation hovering
* Add badges to node db ids etc on node page
* Fix links on node page
* Fix failing test
* Cleanup css
* Remove TODO
* Remove circular import
* Make the Card layout more compact
The bootstrap 4 card introduce a strong padding in the card components in the Web UI which leads to a blown up UI. This commit reduces the padding around the card / box components to make the UI layout more compact.
* Try to use SVG first and fallback to PNG
* Add space to have a better size/space ratio.
* bootstrap-rework: Removed Custom css for the id: access, since it seems out of use
* Fix svg logo sizing
* Revert padding of headers
* Make datetime better readable
* Remove unused wallpaper
* Point to opennms documentation landing page
* Fix navbar nav spacing and make time disappear when burger icon is shown
* Fix navigation sidebar in surveillance view
* Fix font-awesome icons not showing in vaadin aplications
* Fix different navbar in vaadin
* Adjust card spacing (make it smaller)
* Make fonts a tiny bit smaller
* Reduce spacing of breadcrumbs
* Fix some rendering issues with vaadin and navbar
* Fix detail pages in chrome/safari
* Make growl notifications content align correctly
* Fixup Classification UI (mostly spacing issues)
* Change link color to darker blue
* Make card header background darker (same as breadcrumb background)
* Rework header
* Fix color
* Fix bidirectional icons not showing up in classification ui
Bamboo Administrator
Automatically assigned
Christian Pape
Automatically assigned
Jesse White
Automatically assigned
Benjamin Reed
Automatically assigned
Antonio Russo
Automatically assigned
